The Bakery Everything CakePHP

• 

  alexparker
  Posted 04/15/11 09:14:54 PM

  I dropped it in, and updated an existing root task to be a child of another root task, so
  Task A was id:1, lft:1, rght:2, level:0, root:1
  Task B was id:2, lft:1, rght:2, level:0, root:2
  
  i ran $Task->id = 2; $Task->save(array('parent_id'=>1)); And then i was left with:
  Task A was id:1, lft:1, rght:4, level:0, root:1
  Task B was id:2, lft:2, rght:5, level:1, root:1
  
  It almost got it. Then if you continue to set/modify the parent_id value to other roots, it causes all sorts of left/right messes. I'm really new to the whole left/right thing and I've never jumped into making my own behaviors yet, so I'm not sure how to diagnose or fix it. Just wanted to bring it to attention, and hopefully someone knows how to fix it.

  Report this
• 

  -Ste-
  Posted 11/30/10 11:25:14 AM

  oh,my, my..
  it was my mistake. I was updating old code with wrong assumptions.
  Sorry.
  
  
  As cyberthom pointed out on Github, my previous "patch" had an obvious problem - $Model->alias[$this->settings[$Model->alias]['root']] was wrong, $Model->alias is a string, I actually meant $Model->data[$Model->alias][$this->settings[$Model->alias]['root']]
  
  but the real issue was elsewhere.
  
  I actually had records gruoped by another field, and every group could have many trees. So, what I needed was an additional filter by Model::gruop_id, not a filter by root_id (I assumed they were the same, it wasn't)
  
  So i refactored a little, adding a new parameter in $_defaults (handled in setup(), and used in repair() to filter the records to update)
  
  I'll not add a pull requst on github, because it's probably an edge case.
  Here is what I've added, it could be useful for someone with the same setup.
  
  Add a new parameter:
  
var $_defaults = array(
        // Field names
        [..]
        'filter' => null, // i.e. group_id, for gruoped trees and repair only selected gorup
        [..]
    );

  handle it in setup()
  
if ( !empty($this->settings[$Model->alias]['fiter']) ) {
                // if ( !$Model->hasField($this->settings[$Model->alias]['root']) )
                $this->settings[$Model->alias]['__treeFields'][] = $this->settings[$Model->alias]['filter'];
            }

  In repair() replace:
  
  $data = array_fill_keys(array_diff($__treeFields, array($parent, $root)), null); // PHP5.2
  $Model->updateAll($data);
  
  with:
  
$data = array_fill_keys(array_diff($__treeFields, array($parent,$root)), null); // PHP5.2
    
                if(!is_null($Model->data[0][$Model->alias][$this->settings[$Model->alias]['filter']])) 
                    $filter = $Model->data[0][$Model->alias][$this->settings[$Model->alias]['filter']];
                
                else if (!is_null($Model->data[$Model->alias][$this->settings[$Model->alias]['filter']])) 
                    $filter = $Model->data[$Model->alias][$this->settings[$Model->alias]['filter']];
                
                if(!isset($filter)) 
                    $Model->updateAll($data);
                else 
                    $Model->updateAll($data, array($this->settings[$Model->alias]['filter'] =>  $filter));


  
  Of course, update your model properly
  
var $actsAs = array(                
                'MultiTree' => array(
                                    'root' =>'root_id',
                    'level' =>'level_deep',
                    'filter' => 'group_id'
                )
                );

  It's not properly tested, take it as a suggestion if you need grouped trees

  Report this
• 

  -Ste-
  Posted 11/30/10 06:49:50 AM

  I'm Sorry, I replied to the wrong thread. I'll repost here as a new comments thread.
  
  About repair('tree') sets most of other trees records to null:
  
  Hello, I had the same problem.
  I don't know if this is the best solution, but here is a patch that works for me. (Or, so it seems until next disaster)
  
  Problem: when you call repair('tree') the current tree is correctly repaired, but other trees are broken ($__treeFields set to null)
  
  The problem probably lies -in the MultiTreeBehaviour::repair() method- in the $Model->updateAll($data) call, without conditions (-> update EVERY record, setting left, right, and root id to null..)
  
  telling the method to update ONLY the records of the current tree should be enough:
  
  change line 1048
  (see https://github.com/cyberthom/MultiTree-Behavior/blob/master/models/behaviors/multi_tree.php version 0.3)
  
  to
  
  $Model->updateAll($data, array($this->settings[$Model->alias]['root'] => $Model->alias[$this->settings[$Model->alias]['root']]));
  
  (should i fork the code on github? It's just one line.. and I still have to check for side effects)
  
  HTH,
  Stefano
  [end quote]

  Report this
• 

  ctoa
  Posted 05/23/10 04:51:48 PM

  I'm not sure if this project is still active, but it looks very interesting. In a current project I am in need of tracking multiple trees in a single table. I have tried to use this behavior without success. I have created 2 root nodes using the behavior. Later, when I try to add children a node is created but the parent, root, lft, adn rght fields are all null. Am I doing something wrong here.
  
var $actsAs = array( 
    'MultiTree' => array(
        'root' => 'root_id',
        'parent' => 'parent_id',
        'level' => 'level',
    ),
    'Revision', 
    'Logable',        
);

function CreateChild( $parentID )
{
    $newID = false;
        
    $numChildren = $this->getChildCount( $parentID );
    $parent = $this->GetBaseInfo( $parentID );
    
        $this->id = false;
        
    $data = array(
        'root_id' => $parent['TaskTemplate']['root_id'],
        'parent_id' => $parentID,
        'title' => 'New Task-' . $parentID . '-' . ($numChildren + 1),
        'description' => 'Please enter a description or this task.',
        'priority' => $parent['TaskTemplate']['priority'],
        'required' => $parent['TaskTemplate']['required'],
        'deleted' => 0,
    );
    
    if ( $this->save( $data ) )
    {
        #debug( $data );
        $newID = $this->id;
    }
    
    return $newID;
}


  I noticed in the behavior you remove the parent and root fields. Why is this? I appreciate any help you can offer.

  Report this
  • 

    aldo
    Posted 05/25/10 04:57:48 AM

    Similar problem with the NULL values here. When using repair everything is reset to 0.

    Report this
• 

  LDSign
  Posted 05/08/10 11:40:17 AM

  Hi
  
  Reordering the parents (parent_id=NULL) with moveUp and moveDown does not work. Both functions return false. Reordering of any >1 level childs work as normal. Do you have any hints on this issue?
  
  Thanks,
  Frank

  Report this
  • 

    Mr5o1
    Posted 01/04/11 07:16:49 PM

    This is a great behaviour, its been really helpful.
    
    As LDSign mentioned 05/08/10.. there's something wrong with the move functions when called on parents.
    For example, say you want to move the following node:
    
id: 100
root_id: 20
parent: null
lft: 1
rght: 2
The following will occur:
    
$this->Model->moveDown(100);
//returns true, DELETES NODE ?!, not sure of lft & rght of other nodes is updated
$this->Model->move(100, null, 'lastChild'); //or some such
//returns true, creates a NEW TREE for the node (with root_id 101) ?!
In fairness... move() is "undocumented"... having looked at it briefly the third $dest param can be an array in which you can specify a root_id, to avoid having a new tree created:
    
$dest = array(
'parent' => null,
'root' => 20
//can specify 'position' here also? unconfirmed
);
$this->Model->move(100, $dest, 'lastChild');
//moves the node to the lastChild of the root = 20 tree. As expected.

    Hope this saves someone else a bit of time.. took me a while to track down.
    Not sure if its a 'bug' per se, maybe moveDn & moveUp just need to be updated to pass $dest as an array containing 'root' & 'parent'.

    Report this
  • 

    -Ste-
    Posted 11/30/10 05:14:36 AM

    [quote] Hi
    
    Reordering the parents (parent_id=NULL) with moveUp and moveDown does not work. Both functions return false. Reordering of any >1 level childs work as normal. Do you have any hints on this issue?
    
    Thanks,
    Frank
    [end quote]
    Hello, I had the same problem.
    I don't know if this is the best solution, but here is a patch that works for me. (Or, so it seems until next disaster)
    
    Problem: when you call repair('tree') the current tree is correctly repaired, but other trees are broken ($__treeFields set to null)
    
    The problem probably lies -in the MultiTreeBehaviour::repair() method- in the $Model->updateAll($data) call, without conditions (-> update EVERY record, setting left, right, and root id to null..)
    
    telling the method to update ONLY the records of the current tree should be enough:
    
    change line 1048
    (see https://github.com/cyberthom/MultiTree-Behavior/blob/master/models/behaviors/multi_tree.php version 0.3)
    
    to
    
    $Model->updateAll($data, array($this->settings[$Model->alias]['root'] => $Model->alias[$this->settings[$Model->alias]['root']]));
    
    (should i fork the code on github? It's just one line.. and I still have to check for side effects)
    
    HTH,
    Stefano

    Report this
• 

  aldo
  Posted 04/16/10 07:43:45 AM

  Hello,
  
  When we run the repair function all the values for lft, rght, root_id and level of most tree entries are reset to 0.
  
  Any idea whre to start looking for the error?
  
  Thanks!
  Aldo

  Report this
• 

  aldo
  Posted 03/31/10 02:11:11 AM

  Nobody?
  
  Do I still need http://bakery.cakephp.org/articles/view/scopedtreebehavior additionally to handle different trees in one table?
  
  Thanks!

  Report this
  • 

    cyberthom
    Posted 03/31/10 03:26:39 AM

    Do I still need http://bakery.cakephp.org/articles/view/scopedtreebehavior additionally to handle different trees in one table?
    No, the whole point of this behavior is to store multiple trees in one table - they are separated by a root_id

    Report this
• 

  aldo
  Posted 03/25/10 09:05:14 AM

  Hello,
  
  Can this plugin handle different trees in one table?

  Report this
• 

  Dieter_be
  Posted 02/01/10 08:53:16 AM

  > Easier moving of nodes (MultiTree supports full move() to any id as
  > opposed to Core Tree's moveUp and moveDown)
  
  note that you can very easily do this with cake's treebehavior also.
  See http://book.cakephp.org/view/521/Modifying-data
  

  Report this
  • 

    cyberthom
    Posted 02/01/10 09:01:24 AM

    > Easier moving of nodes (MultiTree supports full move() to any id as
    > opposed to Core Tree's moveUp and moveDown)
    
    note that you can very easily do this with cake's treebehavior also.
    See http://book.cakephp.org/view/521/Modifying-data
    good point - however MultiTree allows you to specify the _exact_ position:
    
    $format = array(
    'name' => 'Lion',
    'parent_id' => array('destination' => 4, 'position' => 'nextSibling')
    );
    $this->Category->save($format);

    Report this
• 

  cyberthom
  Posted 01/27/10 08:17:49 AM

  You're welcome guys - Hope it helps!
  
  I've added a public repository in case someone finds any bugs and wants to fix them or add any features: http://github.com/cyberthom/MultiTree-Behavior (fork away!)

  Report this
• 

  toyosawa
  Posted 01/27/10 07:07:10 AM

  Thanks for your help.

  Report this
• 

  zoghal
  Posted 01/26/10 12:51:44 PM

  very very very tnx

  Report this

Comments are closed for articles over a year old